From: Robert Lipe <robertlipe@gpsbabel.org>
Date: Thu, 20 Dec 2018 04:15:01 +0000 (-0600)
Subject: XmlStreamWriter: make single arg methods explicit. Drop unused methods.
X-Git-Tag: archive/raspbian/1.10.0+ds-2+rpi1~1^2~12^2~8^2~26^2~11
X-Git-Url: https://dgit.raspbian.org/%22http:/www.example.com/cgi/%22https://%22Program/%22http:/www.example.com/cgi/%22https:/%22Program?a=commitdiff_plain;h=d9a348dfe77c381d49f9473bca41097d12aa8f19;p=gpsbabel.git

XmlStreamWriter: make single arg methods explicit. Drop unused methods.
---

diff --git a/src/core/xmlstreamwriter.cc b/src/core/xmlstreamwriter.cc
index 70c59fc21..fa74d7c31 100644
--- a/src/core/xmlstreamwriter.cc
+++ b/src/core/xmlstreamwriter.cc
@@ -88,14 +88,6 @@ void XmlStreamWriter::writeStartDocument()
   writeProcessingInstruction(QStringLiteral("xml version=\"1.0\" encoding=\"UTF-8\""));
 }
 
-// Dont emit the attribute if there's nothing interesting in it.
-void XmlStreamWriter::writeOptionalAttribute(const QString& qualifiedName, const QString& value)
-{
-  if (!value.isEmpty()) {
-    QXmlStreamWriter::writeAttribute(qualifiedName, value);
-  }
-}
-
 // Dont emit the element if there's nothing interesting in it.
 void XmlStreamWriter::writeOptionalTextElement(const QString& qualifiedName, const QString& text)
 {
diff --git a/src/core/xmlstreamwriter.h b/src/core/xmlstreamwriter.h
index 829a421cf..77290cca4 100644
--- a/src/core/xmlstreamwriter.h
+++ b/src/core/xmlstreamwriter.h
@@ -49,11 +49,10 @@ protected:
 class XmlStreamWriter : public QXmlStreamWriter
 {
 public:
-  XmlStreamWriter(QString* string);
-  XmlStreamWriter(QFile* f);
+  explicit XmlStreamWriter(QString* string);
+  explicit XmlStreamWriter(QFile* f);
 
-  void writeStartDocument(void);
-  void writeOptionalAttribute(const QString& qualifiedName, const QString& value);
+  void writeStartDocument();
   void writeOptionalTextElement(const QString& qualifiedName, const QString& text);
 };